rails.git
2 years agoMerge branch 'master' into cancancan
Andy Allan [Wed, 31 Oct 2018 10:16:47 +0000 (11:16 +0100)]
Merge branch 'master' into cancancan

2 years agoUpdate mailmap
Tom Hughes [Mon, 29 Oct 2018 12:48:32 +0000 (12:48 +0000)]
Update mailmap

2 years agoUpdate translation keys for renaming of user to users
Tom Hughes [Mon, 29 Oct 2018 12:45:17 +0000 (12:45 +0000)]
Update translation keys for renaming of user to users

2 years agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Mon, 29 Oct 2018 07:12:55 +0000 (08:12 +0100)]
Localisation updates from https://translatewiki.net.

2 years agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Thu, 25 Oct 2018 08:31:58 +0000 (10:31 +0200)]
Localisation updates from https://translatewiki.net.

2 years agoCheck the oauth token and then use the capabilities directly
Andy Allan [Wed, 24 Oct 2018 14:48:54 +0000 (16:48 +0200)]
Check the oauth token and then use the capabilities directly

2 years agoRework capabilities to avoid assumptions about missing tokens
Andy Allan [Wed, 24 Oct 2018 10:07:00 +0000 (12:07 +0200)]
Rework capabilities to avoid assumptions about missing tokens

The logic about missing tokens implying logged in users (and that
all logged in users have access to any method protected by a token
capability) is correct. However, I believe it is both confusing and
brittle, and leaves a security-related door ajar for future foot-gun
incidents.

Instead, apply Abilities as normal, and keep the Capabilities
involvement only for situations where a token is provided. This
reduces the cognitive burden when considering Abilities in isolation.

2 years agoRework the default denied access handler to give different responses to tokens, logge...
Andy Allan [Wed, 24 Oct 2018 07:39:02 +0000 (09:39 +0200)]
Rework the default denied access handler to give different responses to tokens, logged in users and other users

2 years agoUpdate translation keys for renaming of user to users
Tom Hughes [Mon, 22 Oct 2018 09:59:05 +0000 (10:59 +0100)]
Update translation keys for renaming of user to users

Fixes #2031

2 years agoEnable line breaks in performatted text within rich text
Christopher Bazin [Tue, 29 May 2018 04:07:53 +0000 (21:07 -0700)]
Enable line breaks in performatted text within rich text

This stops redaction details being truncated at the edge of the
page when they have long lines of preformatted text.

Also use a div instead of a paragraph for redaction details so
that formatting is consistent with other rich text blocks.

Closes #1885
Fixes #1845

2 years agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Mon, 22 Oct 2018 06:08:50 +0000 (08:08 +0200)]
Localisation updates from https://translatewiki.net.

2 years agoCalculate bounding box when deleting relations
Simon Poole [Sun, 21 Oct 2018 18:32:12 +0000 (19:32 +0100)]
Calculate bounding box when deleting relations

Closes #2030
Fixes #2020

2 years agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Thu, 18 Oct 2018 06:27:45 +0000 (08:27 +0200)]
Localisation updates from https://translatewiki.net.

2 years agoAvoid swapping min and max longitude in RTL mode
superDoss [Wed, 17 Oct 2018 19:37:18 +0000 (22:37 +0300)]
Avoid swapping min and max longitude in RTL mode

Closes #2027

2 years agoCombine site permissions declarations
Andy Allan [Wed, 17 Oct 2018 11:33:47 +0000 (13:33 +0200)]
Combine site permissions declarations

2 years agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Mon, 15 Oct 2018 07:35:52 +0000 (09:35 +0200)]
Localisation updates from https://translatewiki.net.

2 years agoadd australia copyright notice for PSMA Australia
Andrew Harvey [Sun, 14 Oct 2018 12:10:30 +0000 (23:10 +1100)]
add australia copyright notice for PSMA Australia

2 years agoResize change bounding boxes on a zoom change
Tom Hughes [Sun, 14 Oct 2018 11:28:26 +0000 (12:28 +0100)]
Resize change bounding boxes on a zoom change

2 years agoEnable automatic translation export in the test environment
Tom Hughes [Thu, 11 Oct 2018 18:14:55 +0000 (19:14 +0100)]
Enable automatic translation export in the test environment

Fixes #2016

2 years agoAdjust minimum changeset bbox to 20 pixels
Tom Hughes [Thu, 11 Oct 2018 17:52:00 +0000 (18:52 +0100)]
Adjust minimum changeset bbox to 20 pixels

2 years agoImprove variable naming
Tom Hughes [Thu, 11 Oct 2018 17:51:45 +0000 (18:51 +0100)]
Improve variable naming

2 years agoMerge remote-tracking branch 'upstream/pull/2018'
Tom Hughes [Thu, 11 Oct 2018 17:47:47 +0000 (18:47 +0100)]
Merge remote-tracking branch 'upstream/pull/2018'

2 years agoTidy up notes#search
Tom Hughes [Thu, 11 Oct 2018 17:32:31 +0000 (18:32 +0100)]
Tidy up notes#search

2 years agoUse "user" as user id parameter for notes searches
Tom Hughes [Thu, 11 Oct 2018 17:30:53 +0000 (18:30 +0100)]
Use "user" as user id parameter for notes searches

2 years agoMerge remote-tracking branch 'upstream/pull/1955'
Tom Hughes [Thu, 11 Oct 2018 16:41:47 +0000 (17:41 +0100)]
Merge remote-tracking branch 'upstream/pull/1955'

2 years agoSuppress changeset pagination for inactive users
Tom Hughes [Thu, 11 Oct 2018 08:33:24 +0000 (09:33 +0100)]
Suppress changeset pagination for inactive users

Fixes #2024

2 years agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Thu, 11 Oct 2018 07:13:43 +0000 (09:13 +0200)]
Localisation updates from https://translatewiki.net.

2 years agoFix Rubocop issue
ENT8R [Thu, 11 Oct 2018 06:36:13 +0000 (08:36 +0200)]
Fix Rubocop issue

2 years agoFix some issues and improve code
ENT8R [Wed, 10 Oct 2018 17:29:11 +0000 (19:29 +0200)]
Fix some issues and improve code

2 years agoRemove temporary development code
Andy Allan [Wed, 10 Oct 2018 14:54:16 +0000 (16:54 +0200)]
Remove temporary development code

2 years agoRefactor to show the Issues link based on the calculated permissions
Andy Allan [Wed, 10 Oct 2018 14:42:01 +0000 (16:42 +0200)]
Refactor to show the Issues link based on the calculated permissions

2 years agoMove issues and reports to authorization system
Andy Allan [Wed, 10 Oct 2018 14:34:44 +0000 (16:34 +0200)]
Move issues and reports to authorization system

2 years agoFix typo in method name
Andy Allan [Wed, 10 Oct 2018 09:55:00 +0000 (11:55 +0200)]
Fix typo in method name

2 years agoRefactor site#welcome to use abilities instead of require_user
Andy Allan [Wed, 10 Oct 2018 09:49:45 +0000 (11:49 +0200)]
Refactor site#welcome to use abilities instead of require_user

2 years agoChange abilities based on upstream renamings
Andy Allan [Wed, 10 Oct 2018 09:40:41 +0000 (11:40 +0200)]
Change abilities based on upstream renamings

2 years agoMerge branch 'authz' of https://github.com/rubyforgood/openstreetmap-website into...
Andy Allan [Wed, 10 Oct 2018 09:26:30 +0000 (11:26 +0200)]
Merge branch 'authz' of https://github.com/rubyforgood/openstreetmap-website into rubyforgood-authz

2 years agoMake paragraph breaks more visible in changeset and note comments
Tom Hughes [Tue, 9 Oct 2018 14:14:35 +0000 (15:14 +0100)]
Make paragraph breaks more visible in changeset and note comments

Fixes #2022

2 years agoFix Rubocop issue
ENT8R [Tue, 9 Oct 2018 12:50:55 +0000 (14:50 +0200)]
Fix Rubocop issue

2 years agoFix an issue where the query did not work if a display name or an id was specified
ENT8R [Tue, 9 Oct 2018 12:37:55 +0000 (14:37 +0200)]
Fix an issue where the query did not work if a display name or an id was specified

2 years agoMerge branch 'master' into notes-search
ENT8R [Tue, 9 Oct 2018 09:41:22 +0000 (11:41 +0200)]
Merge branch 'master' into notes-search

2 years agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Tue, 9 Oct 2018 08:29:33 +0000 (10:29 +0200)]
Localisation updates from https://translatewiki.net.

2 years agoConverted to dot notation - fixes jshint
J Guthrie [Sat, 6 Oct 2018 23:52:11 +0000 (00:52 +0100)]
Converted to dot notation - fixes jshint

2 years agoConvert degrees min-width to pixels min-width
J Guthrie [Sat, 6 Oct 2018 23:33:54 +0000 (00:33 +0100)]
Convert degrees min-width to pixels min-width

2 years agoRename CSS class matches for change in controller name
Tom Hughes [Thu, 4 Oct 2018 21:32:10 +0000 (22:32 +0100)]
Rename CSS class matches for change in controller name

2 years agoRemove temorary routes
Tom Hughes [Wed, 3 Oct 2018 21:50:43 +0000 (22:50 +0100)]
Remove temorary routes

2 years agoImprove formatting
Tom Hughes [Wed, 3 Oct 2018 21:39:27 +0000 (22:39 +0100)]
Improve formatting

2 years agoMerge remote-tracking branch 'upstream/pull/2010'
Tom Hughes [Wed, 3 Oct 2018 21:39:17 +0000 (22:39 +0100)]
Merge remote-tracking branch 'upstream/pull/2010'

2 years agoUpdated min bounds algorithm
J Guthrie [Wed, 3 Oct 2018 21:07:20 +0000 (22:07 +0100)]
Updated min bounds algorithm

2 years agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Wed, 3 Oct 2018 20:18:47 +0000 (22:18 +0200)]
Localisation updates from https://translatewiki.net.

2 years agoMerge remote-tracking branch 'upstream/pull/2014'
Tom Hughes [Wed, 3 Oct 2018 17:59:33 +0000 (18:59 +0100)]
Merge remote-tracking branch 'upstream/pull/2014'

2 years agoMerge remote-tracking branch 'upstream/pull/2012'
Tom Hughes [Wed, 3 Oct 2018 17:54:19 +0000 (18:54 +0100)]
Merge remote-tracking branch 'upstream/pull/2012'

2 years agoRename user_controller to users_controller
Andy Allan [Wed, 3 Oct 2018 13:31:10 +0000 (15:31 +0200)]
Rename user_controller to users_controller

2 years agoRemove rubocop reference to quad_tile code
Andy Allan [Wed, 3 Oct 2018 12:07:10 +0000 (14:07 +0200)]
Remove rubocop reference to quad_tile code

2 years agoMerge branch 'master' into messages
Andy Allan [Wed, 3 Oct 2018 12:04:12 +0000 (14:04 +0200)]
Merge branch 'master' into messages

2 years agoBump max blocklength for additional routes
Andy Allan [Wed, 3 Oct 2018 12:00:38 +0000 (14:00 +0200)]
Bump max blocklength for additional routes

2 years agoChangeset boundary is enlarged if it was on a single point
J Guthrie [Tue, 2 Oct 2018 22:56:42 +0000 (23:56 +0100)]
Changeset boundary is enlarged if it was on a single point

2 years agoUse sshfs in preference to nfs for vagrant file sharing
Tom Hughes [Fri, 28 Sep 2018 18:51:26 +0000 (19:51 +0100)]
Use sshfs in preference to nfs for vagrant file sharing

2 years agoUpdate vagrant config to use Ubuntu 18.04
Tom Hughes [Fri, 28 Sep 2018 18:51:09 +0000 (19:51 +0100)]
Update vagrant config to use Ubuntu 18.04

2 years agoUpdate wiki page data
Tom Hughes [Wed, 26 Sep 2018 22:28:40 +0000 (23:28 +0100)]
Update wiki page data

2 years agoStop wiki update script trying to be "helpful"
Tom Hughes [Wed, 26 Sep 2018 21:43:30 +0000 (22:43 +0100)]
Stop wiki update script trying to be "helpful"

Instead of trying to advise how to import some (but not all) of
the modules, just require them in the normal way.

Closes #1763

2 years agoFix any_relations always being false
Xuyang Jia [Sat, 22 Sep 2018 16:40:44 +0000 (17:40 +0100)]
Fix any_relations always being false

Closes #1976

2 years agoFix Style/NumericPredicate rubocop warnings
Tom Hughes [Sat, 22 Sep 2018 16:34:58 +0000 (17:34 +0100)]
Fix Style/NumericPredicate rubocop warnings

2 years agoFix Style/SafeNavigation rubocop warnings
Tom Hughes [Sat, 22 Sep 2018 16:21:06 +0000 (17:21 +0100)]
Fix Style/SafeNavigation rubocop warnings

2 years agoFix new rubocop warnings
Tom Hughes [Sat, 22 Sep 2018 16:12:29 +0000 (17:12 +0100)]
Fix new rubocop warnings

2 years agoUpdate bundle
Tom Hughes [Sat, 22 Sep 2018 16:08:49 +0000 (17:08 +0100)]
Update bundle

2 years agoMerge remote-tracking branch 'upstream/pull/2000'
Tom Hughes [Sat, 22 Sep 2018 16:03:50 +0000 (17:03 +0100)]
Merge remote-tracking branch 'upstream/pull/2000'

2 years agoMerge remote-tracking branch 'upstream/pull/2001'
Tom Hughes [Sat, 22 Sep 2018 16:02:50 +0000 (17:02 +0100)]
Merge remote-tracking branch 'upstream/pull/2001'

2 years agoRemove Imperial from hosting credits
Tom Hughes [Sat, 22 Sep 2018 15:57:53 +0000 (16:57 +0100)]
Remove Imperial from hosting credits

Fixes #1944

2 years agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Thu, 20 Sep 2018 09:16:54 +0000 (11:16 +0200)]
Localisation updates from https://translatewiki.net.

2 years agoFix incorrect reference to 12.04 in installation notes
Andy Allan [Wed, 19 Sep 2018 13:34:49 +0000 (14:34 +0100)]
Fix incorrect reference to 12.04 in installation notes

2 years agoSet the rubocop target version to 2.3
Andy Allan [Wed, 19 Sep 2018 13:25:31 +0000 (14:25 +0100)]
Set the rubocop target version to 2.3

This allows rubocop to run additional cops that would not apply to
older ruby versions

2 years agoRemove bogus translation
Tom Hughes [Thu, 13 Sep 2018 18:36:32 +0000 (19:36 +0100)]
Remove bogus translation

2 years agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Mon, 17 Sep 2018 06:17:04 +0000 (08:17 +0200)]
Localisation updates from https://translatewiki.net.

2 years agoRemove bogus translation
Tom Hughes [Thu, 13 Sep 2018 18:36:32 +0000 (19:36 +0100)]
Remove bogus translation

2 years agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Thu, 13 Sep 2018 09:04:58 +0000 (11:04 +0200)]
Localisation updates from https://translatewiki.net.

2 years agoTest that friends are shown correctly on the user profile
Tom Hughes [Wed, 12 Sep 2018 16:57:09 +0000 (17:57 +0100)]
Test that friends are shown correctly on the user profile

Fixes #1992

2 years agoSet img.button size to 20x20 for directions.png
mmd-osm [Tue, 11 Sep 2018 17:47:42 +0000 (19:47 +0200)]
Set img.button size to 20x20 for directions.png

2 years agoUpdate translation keys for renaming of user#view to user#show
Tom Hughes [Tue, 11 Sep 2018 15:33:46 +0000 (16:33 +0100)]
Update translation keys for renaming of user#view to user#show

2 years agoUpdate bundle
Tom Hughes [Mon, 10 Sep 2018 21:40:21 +0000 (22:40 +0100)]
Update bundle

2 years agoUpdate bowser to 1.9.4
Tom Hughes [Mon, 10 Sep 2018 21:33:46 +0000 (22:33 +0100)]
Update bowser to 1.9.4

2 years agoUpdate leaflet to 1.3.4
Tom Hughes [Mon, 10 Sep 2018 21:30:01 +0000 (22:30 +0100)]
Update leaflet to 1.3.4

2 years agoAvoid flickering welcome banner
Tom Hughes [Mon, 10 Sep 2018 20:21:43 +0000 (21:21 +0100)]
Avoid flickering welcome banner

Make the welcome banner default to being hidden and then show
it (by adding a class) if there is no cookie.

Fixes #1951

2 years agoLimit map to the maximum zoom of the current base layer
Tom Hughes [Mon, 10 Sep 2018 19:37:36 +0000 (20:37 +0100)]
Limit map to the maximum zoom of the current base layer

Fix maximum zoom levels for various layers and ensure that the
map can't be zoomed beyond the limit of the current base layer.

Fixes #1978

2 years agoMerge remote-tracking branch 'upstream/pull/1987'
Tom Hughes [Mon, 10 Sep 2018 18:09:31 +0000 (19:09 +0100)]
Merge remote-tracking branch 'upstream/pull/1987'

2 years agoMerge remote-tracking branch 'upstream/pull/1986'
Tom Hughes [Mon, 10 Sep 2018 18:01:28 +0000 (19:01 +0100)]
Merge remote-tracking branch 'upstream/pull/1986'

2 years agoMerge remote-tracking branch 'upstream/pull/1985'
Tom Hughes [Mon, 10 Sep 2018 17:58:27 +0000 (18:58 +0100)]
Merge remote-tracking branch 'upstream/pull/1985'

2 years agoMerge remote-tracking branch 'upstream/pull/1984'
Tom Hughes [Mon, 10 Sep 2018 17:53:13 +0000 (18:53 +0100)]
Merge remote-tracking branch 'upstream/pull/1984'

2 years agoMerge remote-tracking branch 'upstream/pull/1983'
Tom Hughes [Mon, 10 Sep 2018 17:53:09 +0000 (18:53 +0100)]
Merge remote-tracking branch 'upstream/pull/1983'

2 years agoRename CSS class matches for changes in action names
Tom Hughes [Mon, 10 Sep 2018 13:11:19 +0000 (14:11 +0100)]
Rename CSS class matches for changes in action names

2 years agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Mon, 10 Sep 2018 06:30:56 +0000 (08:30 +0200)]
Localisation updates from https://translatewiki.net.

2 years agoResolve 34 Rubocop Lint/AmbiguousOperator conflicts
Wil [Fri, 8 Jun 2018 19:02:03 +0000 (15:02 -0400)]
Resolve 34 Rubocop Lint/AmbiguousOperator conflicts

2 years agoRemove Lint/ShadowingOuterLocalVariable - already fixed
Andy Allan [Mon, 10 Sep 2018 03:34:04 +0000 (11:34 +0800)]
Remove Lint/ShadowingOuterLocalVariable - already fixed

2 years agoResolve 96 Rubocop Lint/AmbiguousRegexpLiteral conflicts
Wil [Fri, 8 Jun 2018 19:51:17 +0000 (15:51 -0400)]
Resolve 96 Rubocop Lint/AmbiguousRegexpLiteral conflicts

2 years agoJust pass the object, rather than the id, to _path methods where possible
Andy Allan [Mon, 10 Sep 2018 03:09:19 +0000 (11:09 +0800)]
Just pass the object, rather than the id, to _path methods where possible

2 years agoJust pass the user object, rather than the display_name, to the user_path helper
Andy Allan [Mon, 10 Sep 2018 02:54:29 +0000 (10:54 +0800)]
Just pass the user object, rather than the display_name, to the user_path helper

2 years agoRename diary_entry#list to #index
Andy Allan [Mon, 10 Sep 2018 02:26:28 +0000 (10:26 +0800)]
Rename diary_entry#list to #index

2 years agoRename user#list to user#index
Andy Allan [Mon, 10 Sep 2018 02:03:34 +0000 (10:03 +0800)]
Rename user#list to user#index

2 years agoUse full url escaping when required in trace tests
Andy Allan [Mon, 10 Sep 2018 01:37:52 +0000 (09:37 +0800)]
Use full url escaping when required in trace tests

2 years agoUpdate changeset browse view for renaming of changeset#list to changeset#index
Tom Hughes [Sun, 9 Sep 2018 11:36:34 +0000 (12:36 +0100)]
Update changeset browse view for renaming of changeset#list to changeset#index

2 years agoUpdate trace RSS for renaming of trace#view to trace#show
Tom Hughes [Sun, 9 Sep 2018 10:49:37 +0000 (11:49 +0100)]
Update trace RSS for renaming of trace#view to trace#show